Skip to content

Bookings: Fetch and display assigned staff on booking details #16249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 17, 2025
Merged

Bookings: Fetch and display assigned staff on booking details #16249

merged 8 commits into from
Oct 17, 2025

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Oct 16, 2025 •
edited
Loading

Closes WOOMOB-1522

Description

This PR supports fetching and displaying assigned staff on booking details:

  • Adds readonly model for BookingResource.
  • Integrates /bookings/v2/resources/{id} endpoint
  • Adds CoreData entity for BookingResource to cache results.
  • Updates BookingAction and BookingStore to fetch resources.
  • Updates booking details view to fetch and display resources. Due to the time shortage, I could not polish the UI with proper loading state, so for now the Assigned Staff row shows only "-" while fetching is in progress.

Testing steps

  1. Log in to a CIAB store with existing bookings.
  2. Navigate to the Bookings tab and select a booking with associated order.
  3. Confirm that after a few seconds the assigned staff value is displayed.
  4. Navigate back out and in again to the same booking detail screen.
  5. Confirm that the assigned staff value is available immediately as it was cached from the last fetch.

Testing information

  • Tested with simulator iPhone 17.
  • Added unit tests.

Screenshots

Simulator.Screen.Recording.-.iPhone.17.-.2025-10-16.at.17.43.57.mov
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added this to the 23.5 milestone Oct 16, 2025
@itsmeichigo itsmeichigo added the type: task An internally driven task. label Oct 16, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 16, 2025 •
edited
Loading

2 Warnings
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ This PR is assigned to the milestone 23.5. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@itsmeichigo itsmeichigo requested a review from adborbas October 16, 2025 10:44
@itsmeichigo itsmeichigo marked this pull request as ready for review October 16, 2025 10:44
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 16, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16249-0c2def2
Version23.4
Bundle IDcom.automattic.alpha.woocommerce
Commit0c2def2
Installation URL111qebbg7houo
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

adborbas
adborbas approved these changes Oct 16, 2025
View reviewed changes
Copy link
Contributor

@adborbas adborbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

Base automatically changed from woomob-1510-update-bookingdetails-booking-list to trunk October 17, 2025 01:21
@itsmeichigo itsmeichigo enabled auto-merge October 17, 2025 01:21
@itsmeichigo itsmeichigo merged commit a1b6782 into trunk Oct 17, 2025
13 checks passed
@itsmeichigo itsmeichigo deleted the woomob-1522-ios-fetch-resource branch October 17, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adborbas adborbas adborbas approved these changes

Assignees

No one assigned

Labels

type: task An internally driven task.

Projects

None yet

Milestone

23.5

Development

Successfully merging this pull request may close these issues.

5 participants

@itsmeichigo @dangermattic @wpmobilebot @adborbas